search

open-telemetry / community

OpenTelemetry community content
https://opentelemetry.io
Apache License 2.0
763 stars 231 forks source link

REQUEST: Repository maintenance on opentelemetry-network-build-tools #2387

Open yonch opened 3 days ago

yonch commented 3 days ago

Affected Repository

https://github.com/open-telemetry/opentelemetry-network-build-tools

edit: caption of link

Requested changes

  1. As a maintainer, I'd like to be able to merge my own PRs without another maintainer's review.
  2. The repository should have secrets configured: DOCKER_USERNAME and DOCKER_PASSWORD
  3. The repository should have vars configured: DOCKER_REGISTRY and DOCKER_NAMESPACE

Purpose

This repository is the source needed to build the build-env container for opentelemetry-network. The project uses a build environment to allow contributors to work on the exact same version of dependencies, so contributions compile reliably.

I'm adding GitHub Actions to build and release this build-env. This requires iteration on the main branch and the PR rules make this unwieldy...

Expected Duration

2 weeks for the PR merge.

secrets and vars should remain permanently.

Repository Maintainers

trask commented 2 days ago

I'm adding GitHub Actions to build and release this build-env. This requires iteration on the main branch and the PR rules make this unwieldy...

I usually test GitHub Actions on my fork.

I know @austinlparker uses https://github.com/nektos/act to test GitHub Actions locally.

would either of these approaches alleviate the burden for you?

yonch commented 2 days ago

Thanks for the pointers!

I'm close to the point where I need to test with large builders (the build needs ~50GB of disk space) and don't have access to those on my private account..

I'll get as close as I can with act but if I can't merge into this repo it will likely push this effort beyond Kubecon (I'm working on this on my own time). Would appreciate the merge exception if possible..

yonch commented 1 day ago

All right, the act recommendation was great, thank you @trask !

The opentelemetry-network-build-tools PR is now blocked on PR merges.

Also can someone chime in if DOCKER_* is already available in the repo or it needs to be configured?

trask commented 1 day ago

Also can someone chime in if DOCKER_* is already available in the repo or it needs to be configured?

cc @tigrannajaryan

tigrannajaryan commented 1 day ago
  1. https://hub.docker.com/repository/docker/otel/opentelemetry-network-build-tools docker hub repo is created.
  2. DOCKER_USERNAME and DOCKER_PASSWORD env variables added to https://github.com/open-telemetry/opentelemetry-network-build-tools and should be available to actions.
  3. The user has permissions to Read&Write the docker repo.