search

open-telemetry / opamp-go

OpAMP protocol implementation in Go
Apache License 2.0
141 stars 69 forks source link

Avoid spurious error log for Client.Stop closed connections #203

Closed srikanthccv closed 9 months ago

srikanthccv commented 1 year ago

Co-authored-by: phanidevavarapu

This is a continuation of closed PR https://github.com/open-telemetry/opamp-go/pull/173. Fixes #163

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage is 90.90% of modified lines.

Files Changed Coverage
client/internal/packagessyncer.go 0.00%
client/types/callbacks.go ø
server/httpconnection.go 0.00%
client/internal/mockserver.go 85.71%
server/serverimpl.go 94.73%
client/httpclient.go 100.00%
client/internal/clientcommon.go 100.00%
client/internal/httpsender.go 100.00%
client/internal/receivedprocessor.go 100.00%
client/internal/wsreceiver.go 100.00%
... and 3 more

:loudspeaker: Thoughts on this report? Let us know!.

evan-bradley commented 12 months ago

@srikanthccv @tigrannajaryan I've drafted some changes that I believe may solve the same issue without ignoring the net.ErrClosed error: https://github.com/open-telemetry/opamp-go/pull/205. Please take a look at let me know what your thoughts are.

srikanthccv commented 9 months ago

Closing since there are other pull requests to gracefully close the connection.