open-telemetry / opamp-go

OpAMP protocol implementation in Go
Apache License 2.0
146 stars 71 forks source link

fix sample not works #211

Closed JaredTan95 closed 11 months ago

JaredTan95 commented 12 months ago

fix ui dir cloud not be loaded and certs file path in sample server.

codecov[bot] commented 12 months ago

Codecov Report

Attention: 129 lines in your changes are missing coverage. Please review.

Files Coverage Δ
client/httpclient.go 95.31% <100.00%> (+0.57%) :arrow_up:
client/internal/clientcommon.go 80.47% <100.00%> (+0.67%) :arrow_up:
client/internal/receivedprocessor.go 72.60% <100.00%> (-11.69%) :arrow_down:
client/types/callbacks.go 66.66% <ø> (ø)
server/callbacks.go 68.18% <100.00%> (-4.55%) :arrow_down:
server/wsconnection.go 100.00% <100.00%> (ø)
client/internal/packagessyncer.go 59.25% <0.00%> (ø)
server/serverimpl.go 58.92% <95.00%> (+0.37%) :arrow_up:
server/httpconnection.go 33.33% <0.00%> (ø)
client/internal/mockserver.go 82.35% <85.71%> (+0.31%) :arrow_up:
... and 2 more

... and 3 files with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!

srikanthccv commented 12 months ago

What was the directory you used to run the example server?

JaredTan95 commented 11 months ago

What was the directory you used to run the example server?

Thank you for reminding me that I was in the wrong directory. So, I will close this PR.

srikanthccv commented 11 months ago

You can rely on the run-examples target without worrying about directory stuff.