open-telemetry / opamp-go

OpAMP protocol implementation in Go
Apache License 2.0
146 stars 71 forks source link

Fix set invalid instance UID error throw #218

Closed Sairam-Arpavur-Natarajan closed 10 months ago

Sairam-Arpavur-Natarajan commented 10 months ago

Fixing error throw logger when setting invalid instance UID provided by the server.

linux-foundation-easycla[bot] commented 10 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

tigrannajaryan commented 10 months ago

Thank you for the fix @sairam866 Please sign the CLA so that we can accept the PR.

Sairam-Arpavur-Natarajan commented 10 months ago

@tigrannajaryan Updated my commit with my company email. CLA should be fine now.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (efddaa2) 76.11% compared to head (2d8c193) 72.50%. Report is 32 commits behind head on main.

Files Patch % Lines
internal/certs.go 0.00% 118 Missing :warning:
client/internal/httpsender.go 88.00% 2 Missing and 1 partial :warning:
client/internal/mockserver.go 85.71% 2 Missing and 1 partial :warning:
server/httpconnection.go 0.00% 2 Missing :warning:
client/internal/clientcommon.go 90.90% 1 Missing :warning:
client/internal/packagessyncer.go 0.00% 1 Missing :warning:
client/internal/receivedprocessor.go 90.90% 1 Missing :warning:
server/serverimpl.go 95.65% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #218 +/- ## ========================================== - Coverage 76.11% 72.50% -3.62% ========================================== Files 24 25 +1 Lines 1834 2022 +188 ========================================== + Hits 1396 1466 +70 - Misses 326 446 +120 + Partials 112 110 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tigrannajaryan commented 10 months ago

Thanks @sairam866