Require that instance_uid is ULID instead of only recommending it

open-telemetry / opamp-spec

OpAMP Specification

Apache License 2.0

102 stars 33 forks source link

Require that instance_uid is ULID instead of only recommending it #116

Closed tigrannajaryan closed 2 years ago

tigrannajaryan commented 2 years ago

Resolves https://github.com/open-telemetry/opamp-spec/issues/113

This PR changes ULID to be a MUST in order to:

Avoid mistakes when the Agent chooses too short instance id and causes collisions.
Make the Server's life a bit easier since will know it is always a 128 bits of data and can store in places where UUIDs can be stored (e.g. Postgres has a data type UUID).

tigrannajaryan commented 2 years ago

This will be a breaking change for bindplane-op agents, but I think it is a good change.

Yes. Good news is that this seems to be the last remaining known issue that will be a breaking change. We should probably wait for a bit after merging this one to see if any other issues are discovered that will be also breaking so that we can release them at once (multiple breaking releases are usually more painful - that's why we promise no more frequently than once every 3 months when in Beta).