search

open-telemetry / opamp-spec

OpAMP Specification
Apache License 2.0
102 stars 33 forks source link

Move proto files to opamp-spec repo #126

Closed tigrannajaryan closed 1 year ago

tigrannajaryan commented 1 year ago

Contributes to https://github.com/open-telemetry/opamp-go/issues/133

Now that we are adding OpAMP Java implementation the protos can no longer live in opamp-go. We are moving the protos to the spec repo since it fits this repo's purpose naturally.

The proto files are copied verbatim from opamp-go. Any changes needed in the proto files can be done in a future PR.

In the future it is also worth exploring if we can delete the message definitions from specification.md and instead link them directly to the proto files so that we have a single source of truth.

tigrannajaryan commented 1 year ago

@jlegoff please review.

tigrannajaryan commented 1 year ago

I forgot to add the github action. Done now. The action runs and checks that the protos can be generated in Go.

tigrannajaryan commented 1 year ago

Merging since the build passes and protos are what we need. Any further refinements can be a future PR.