Spec contains an invalid links - Githubissues

open-telemetry / opamp-spec

OpAMP Specification

Apache License 2.0

102 stars 33 forks source link

Spec contains an invalid links #169

Closed chalin closed 7 months ago

chalin commented 10 months ago

$ npx markdown-link-check specification.md 
...

  194 links checked.

  ERROR: 3 dead links found!
  [✖] https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/process-metrics.md → Status: 404
  [✖] https://eng.uber.com/flipr/ → Status: 406
  [✖] https://pwn.recipes/posts/roll-your-own-e2ee-protocol/ → Status: 0

/assign @chalin /cc @svrnm

[x] Fix 404: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/process-metrics.md
- 171
[x] Fix/address 406: https://eng.uber.com/flipr --> note that the following link is valid but still returns a 406 by the Uber server now, https://www.uber.com/en-CA/blog/flipr. So we might just have to ignore it.

chalin commented 10 months ago

Actually, I'll only fix the semconv URL for now.