Amend field names in TLSCertificate message

open-telemetry / opamp-spec

OpAMP Specification

Apache License 2.0

102 stars 33 forks source link

Amend field names in TLSCertificate message #195

Closed tpaschalis closed 2 months ago

tpaschalis commented 2 months ago

Fixes #161

This PR amends two field names in TLSCertificate message, making them more descriptive. I've opted to use the shorter cert term, to avoid confusion with the parent message which is used as TLSCertificate certificate in three places.

It's my first PR to the opamp-spec repo, so let me know if there's something I'm missing, I'd be happy to fix that.

tigrannajaryan commented 2 months ago

Please also make the same changes in https://github.com/open-telemetry/opamp-spec/blob/main/specification.md

tpaschalis commented 2 months ago

Please also make the same changes in https://github.com/open-telemetry/opamp-spec/blob/main/specification.md

Whoops, sorry for missing that 🤦‍♂️ Done.