search

open-telemetry / opamp-spec

OpAMP Specification
Apache License 2.0
102 stars 33 forks source link

Allow setting Headers in DownloadableFile message #197

Closed tpaschalis closed 1 month ago

tpaschalis commented 2 months ago

Fixes #194

This PR amends the spec and protos to include an optional set of headers in DownloadableFile, to be used in the download GET request to set up auth parameters.

This is only one of the ways we could implement setting authentication paramaters to be used by Agents when downloading packages, but it is consistent with other uses of the headers field and generic enough to cover different use cases so I feel it's worth considering.

tpaschalis commented 1 month ago

Once merged let's add corresponding implementation in OpAMP Go.

Yes, I can handle that.

tigrannajaryan commented 1 month ago

@tpaschalis thank you for adding this feature.