Update Spec to include ServerToAgentCommand

open-telemetry / opamp-spec

OpAMP Specification

Apache License 2.0

108 stars 34 forks source link

Update Spec to include ServerToAgentCommand #64

Closed dsvanlani closed 2 years ago

dsvanlani commented 2 years ago

Resolves https://github.com/open-telemetry/opamp-spec/issues/22

Add ServerToAgentCommand into ServerToAgentMessage.
Documents ServerToAgentCommand

linux-foundation-easycla[bot] commented 2 years ago

The committers are authorized under a signed CLA.

:white_check_mark: David VanLaningham (002c99d0a2913994e2c5adc3920785f3ddd42c6a)

tigrannajaryan commented 2 years ago

@open-telemetry/opamp-spec-approvers please review.

tigrannajaryan commented 2 years ago

@dsvanlani Discussed this in the workgroup. There does not seem to be a consensus around what it means to "shutdown" an Agent. Can you clarify the semantics of the operation or perhaps remove it from this PR, so that we can merge "restart" command quickly and continue thinking about shutdown in a follow up PR.

dsvanlani commented 2 years ago

@tigrannajaryan I removed the "shutdown" command from this PR. Happy to wait for further discussion.

tigrannajaryan commented 2 years ago

@dsvanlani please rebase from main and resolve the conflicts so that I can merge.

dsvanlani commented 2 years ago

@tigrannajaryan I went ahead and rebased to cleanup the commit history - I'm not sure why the UI isn't reflecting the single commit.