search

open-telemetry / opamp-spec

OpAMP Specification
Apache License 2.0
108 stars 34 forks source link

Unify addons and agent packages #77

Closed tigrannajaryan closed 2 years ago

tigrannajaryan commented 2 years ago

Addons and agent packages were previously defined separately in the spec but had a lot of similarities. This change combines them into one concept of "packages". The resulting spec is significantly shorter while providing the same functionality. It may also reduce the code duplication in implementations.

Resolves https://github.com/open-telemetry/opamp-spec/issues/4

tigrannajaryan commented 2 years ago

@open-telemetry/opamp-spec-approvers I made this a draft for now, please tell what you think about it.

tigrannajaryan commented 2 years ago

@andykellr it would be also good to have your thoughts on this.

andykellr commented 2 years ago

I can look at it in more detail tomorrow or Wednesday, but at first glance it makes sense to me.

tigrannajaryan commented 2 years ago

@open-telemetry/opamp-spec-approvers I spent a bit more time thinking about this change and feel reasonably confident that this is a move in the right direction. I think this is ready for review.

tigrannajaryan commented 2 years ago

@pmm-sumo it would be great if you could also have a look at this.