search

open-telemetry / opentelemetry-android

OpenTelemetry Tooling for Android
Apache License 2.0
114 stars 22 forks source link

Add androidTests for httpUrlConnection module and create test-common module for common test utilities #452

Open surbhiia opened 1 week ago

surbhiia commented 1 week ago

Related Issue - https://github.com/open-telemetry/opentelemetry-android/issues/148

Feel free to suggest better naming for the new files. One observation I had was that, by naming module "test-common" it moves to the bottom of the list in project view in android studio and if we were to name it "common-test" it would show up right below the "common" module. Let me know if anyone has any preferences here. :)

Screenshot 2024-06-25 at 9 32 46 AM
marandaneto commented 1 week ago

Thanks for adding the tests. It'd be cool if tests were written in Kotlin already, not a blocker at all though.

surbhiia commented 1 week ago

Thanks for adding the tests. It'd be cool if tests were written in Kotlin already, not a blocker at all though.

Will convert this to Kotlin! Not many files in this PR, so should not take long. :)

surbhiia commented 1 week ago

I'll be on PTO next week. Will address any new comments starting next to next week! :)

bidetofevil commented 1 week ago

We talked about wanting all of the code to eventually be Kotlin (I will begin converting soon), so new code, especially tests, should be in Kotlin.

We should add something to the contribution guide about that so anything new is Kotlin unless it really can't be. I can find a place for that.... CC @LikeTheSalad @breedx-splk

LikeTheSalad commented 5 days ago

We talked about wanting all of the code to eventually be Kotlin (I will begin converting soon), so new code, especially tests, should be in Kotlin.

We should add something to the contribution guide about that so anything new is Kotlin unless it really can't be. I can find a place for that.... CC @LikeTheSalad @breedx-splk

I agree, we should add it to the contributing guide.