open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.89k stars 2.27k forks source link

[receiver/snmp] Indexed Attribute & Indexed Metric Datapoint Matching Improvements #15670

Open StefanKurek opened 1 year ago

StefanKurek commented 1 year ago

Describe the issue you're reporting

The SNMP Receiver currently does not check if indexed based attribute or resource attribute values match up well with indexed metric values.

Indexed attribute values that obviously don't match (values might come from a SNMP response with indexes .1.1-.1.10) will currently still be attempted to match with related metrics based on configs (metric datapoint values from an SNMP response might have indexes of .1.1-1.5). Instead more verification could be done that the attributes come from the same table as the metric data points, or at least that the number of retrieved index based attributes would be the same as the number of matching config retrieved index based metric datapoints.

djaglowski commented 1 year ago

Follow up to #15361

github-actions[bot] commented 1 year ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] commented 1 year ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.