Open atoulme opened 11 months ago
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
This issue has been closed as inactive because it has been stale for 120 days with no activity.
@JonathanWamsley, is this something you could pick up?
Hi @JonathanWamsley, are you still working on this issue? If you are busy, i would like try to implement it. I think we would need a feature gate to enable this functionality, right? I can't find the mdatagen built-in feature-gate system
refer to https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/18881#issuecomment-1450474770
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
Looking at this again, I'm unclear on what change is being requested. Is the idea to add a feature gate and migrate towards having this resource enabled by default? Generally when adding new metrics, we've just left them as disabled by default, but I'm not sure if resource attributes have been or should be handled differently.
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
Based on this comment, I understand that mdatagen
now has the ability to set resource attributes as optional or default, but we don't have documentation regarding how to migrate resource attributes from optional to default. I think the mechanism used for metrics is sufficient though, which is to first add a warning log to the receiver which explains that the attribute will be enabled by default starting with a particular version.
Here is an example of how the mechanism is controlled.
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
Component(s)
receiver/mongodbatlas
Is your feature request related to a problem? Please describe.
The PR https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/18881 added the ability to surface
mongodb_atlas.user.alias
but didn't allow for it to be enabled by default.Describe the solution you'd like
This issue tracks enabling this resource attribute by default.
Describe alternatives you've considered
No response
Additional context
No response