search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.91k stars 2.27k forks source link

Add DisablePAFXFAST option to kafka exporter #26345

Open swythan opened 1 year ago

swythan commented 1 year ago

Component(s)

exporter/kafka

Is your feature request related to a problem? Please describe.

When attempting to use kerberos authentication against ActiveDirectotry in the kafka exporter, I get the following error:

[Root cause: KRBMessage_Handling_Error] KRBMessage_Handling_Error: AS Exchange Error: AS_REP is not valid or client password/keytab incorrect < KRBMessage_Handling_Error: KDC did not respond appropriately to FAST negotiation

I'm told that this is because our ActiveDirectory controller doesn't support FAST.

Describe the solution you'd like

Looking further it seems that the sarama library added an option for this, so hopefully it should just be a question of plumbing the config through.

Sarama PR: https://github.com/IBM/sarama/pull/1466 Sarama config docs: https://pkg.go.dev/github.com/IBM/sarama#GSSAPIConfig.DisablePAFXFAST

Describe alternatives you've considered

No response

Additional context

No response

github-actions[bot] commented 1 year ago

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

swythan commented 1 year ago

This seems trivial to add, so I've speculatively made a PR.

github-actions[bot] commented 10 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

swythan commented 10 months ago

This is still something that is needed. Can I get someone interested in reviewing it if I update my PR for the refactoring that has happened underneath me?

github-actions[bot] commented 8 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

swythan commented 8 months ago

@open-telemetry/collector-contrib-triagers is there any point me resolving the conflicts caused by the refactoring on main? How would I get the resulting changes merged?

github-actions[bot] commented 5 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

swythan commented 5 months ago

Still awaiting a response from a maintainer.

sy-be commented 4 months ago

We are having the same issue. Would love to have a fix for this.

sy-be commented 4 months ago

@pavolloffay / @MovieStoreGuy any chance you could look at this issue and the related PR? I think PR needs some rework, but changes look trivial. @swythan , would you be able to update the PR if we all agree on the issue? Thanks all!

sy-be commented 4 months ago

I've created an updated PR to address this: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33086

sy-be commented 2 months ago

The fix has been released now in https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.103.0 This issue can be closed.

github-actions[bot] commented 3 weeks ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.