open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.94k stars 2.29k forks source link

Consider removing cmd/otecontribcol and cmd/otetestbedcol modules #27826

Open dmitryax opened 11 months ago

dmitryax commented 11 months ago

Go code in the cmd/otecontribcol and cmd/otetestbedcol modules is auto-generated using the collector builder. cmd/otecontribcol also has additional lifecycle tests for all the components that do not necessarily belong to that module.

The go modules depend on all the other modules in the contrib repo. This makes the linter take up to 20 minutes just to build AST. The linter job often times out.

Do we really need to keep the generated code? Instead, we can generate the code whenever we need to build the otecontribcol or otetestbedcol artifacts. The lifecycle tests can be moved to each component by autogenerating them with the mdatagen tool.

Action items (assuming the suggestion is accepted):

codeboten commented 11 months ago

I would be ok with removing it, so long as the makefile targets continue to work, that's fine w/ me. We should consider doing the same in core

dmitryax commented 11 months ago

The suggestion was accepted after discussing it in the Collector SIG meeting

jpkrohling commented 11 months ago

I'm in favor of removing it. I'd love to get @bogdandrutu's opinion on this, as I remember him being quite vocal about having that versioned.

atoulme commented 10 months ago

I would like to work on this. I will start with moving the tests out per the list.

github-actions[bot] commented 8 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] commented 6 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

github-actions[bot] commented 3 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

pavankrish123 commented 3 months ago

@atoulme if you are ok with it, I can work on this - Please and thank you.

atoulme commented 3 months ago

Sure thing!