open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.96k stars 2.3k forks source link

Remove generated code from `cmd/otecontribcol` or `cmd/otetestbedcol` #27850

Closed dmitryax closed 18 hours ago

dmitryax commented 11 months ago

Don't need to keep the generated code. We can keep the builder yaml manifests only, and generate the code when it's needed.

  1. Find a better place for the collector builder yaml manifests
  2. Update all the CI steps and make targets to generate the code before building artifacts
  3. Remove the cmd/otecontribcol or cmd/otetestbedcol modules
github-actions[bot] commented 9 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

codeboten commented 9 months ago

come on github-actions, do you not see all the PRs opened on this issue? 😄

github-actions[bot] commented 7 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

mowies commented 1 month ago

I started working on this, draft PR is open but still in progress.

@dmitryax what about the test files found in cmd/otelcontribcol? Also, I will maybe have to keep the dockerfiles to build images of the collector that are needed in the pipeline.

mowies commented 3 weeks ago

@dmitryax any updates on this?

mowies commented 2 weeks ago

maybe somebody else from @open-telemetry/collector-contrib-maintainers ?

mowies commented 2 weeks ago

or @atoulme since you worked in removing things here as well?