open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.73k stars 2.16k forks source link

Implement Connectors into the Testbed #30165

Open humivo opened 6 months ago

humivo commented 6 months ago

Component(s)

testbed

Is your feature request related to a problem? Please describe.

The current Testbed configuration does not support Connectors.

Describe the solution you'd like

I would like the Testbed configuration/data flow to be restructured to accept connectors. For example, in this configuration for correctness tests, allow a connector to be added to the Collector.

Describe alternatives you've considered

No response

Additional context

No response

github-actions[bot] commented 6 months ago

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

humivo commented 6 months ago

I am currently looking into the changes that would need to be made to introduce connectors into the Testbed but would appreciate any input on the approach for this!

humivo commented 6 months ago

Hello, I'm looking for any input on this approach to add connectors to testbed. I initially thought that we could just add in a connector parameter into the CreateConfigYaml() method in correctnesstests and if defined, create a config with 2 pipelines that looks like this:

receivers: sender
exporters: receiver
processors: processors
connectors: connector

extensions:

service:
  extensions:
  pipelines:
    traces:
      receivers: [sender]
      processors: [processors]
      exporters: [connector]
    metrics:
      receivers: [connector]
      exporters: [receiver]

However, I noticed that pipelineType is a required parameter and correctnesstests are split up between traces and metrics so I am not sure how it would handle a traces DataSender but a metrics DataReceiver. Is the answer here to create a new type of tests so that we can create another TestCaseValidator for this use case?

crobert-1 commented 5 months ago

I think this is a good idea, removing the needs triage label.

I don't have much experience with testbed, so unfortunately I don't have any input at this point.

github-actions[bot] commented 3 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] commented 1 month ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.