open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.86k stars 2.23k forks source link

Ensure that all codeowners are members of the OpenTelemetry organization #30552

Open atoulme opened 7 months ago

atoulme commented 7 months ago

Component(s)

No response

Describe the issue you're reporting

See https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/20868 for the last campaign

Not all codeowners of this repository are members of the OpenTelemetry github organization, which membership is associated with membership of the OpenTelemetry project.

The guidelines enforce membership because it allows to assign and ping codeowners on issues or pull requests. Unfortunately, if you try to create an issue or assign a PR to a codeowner who is not member of OpenTelemetry, the workflow fails. I would like to fix this issue.

Going forward, I would also ideally like to make sure that we check that codeowners are members of the github organization whenever the codeowners file is touched.

The process to become a member of OpenTelemetry is straightforward. Open this issue template on the community project to get started.

I have identified a list of codeowners who are not currently members of OpenTelemetry. I will ping them in this issue below.

  1. Please cross your name to indicate you have seen this message.
  2. (optional) Please get in touch over Slack: I have created a slack channel for the purpose of codeowner discussions, #otel-collector. Feel free to reply here as well and provide clarifications if any information is incorrect.
  3. Please work towards membership. Feel free to use 2. for any questions.
  4. If I don't hear from you in the next 60 days (tentative), I will open an issue to follow up. The issue will offer to either help you become a member or open a pull request to move to emeritus status.

Thank you and apologies for the inconvenience.

braydonk commented 7 months ago

I am unable to check the checkbox for my name, but I have seen the issue.

#otel-collector-codeowners is an archived channel, will you be unarchiving it for this issue's purposes?

braydonk commented 7 months ago

I am now a member of the OpenTelemetry GitHub Org.

crobert-1 commented 7 months ago

Just adding a couple reference issues

@braydonk - https://github.com/open-telemetry/community/issues/1877 @zdaratom - https://github.com/open-telemetry/community/issues/1876

github-actions[bot] commented 5 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

zdaratom-s1 commented 5 months ago

"zdaratom" is no longer needed as it has been updated via https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/30639

atoulme commented 5 months ago

I am unable to check the checkbox for my name, but I have seen the issue.

#otel-collector-codeowners is an archived channel, will you be unarchiving it for this issue's purposes?

Sorry, please use #otel-collector instead.

alxbl commented 3 months ago

As of 2024/04/30:

$ githubgen
2024/04/30 10:50:08 codeowners are not members: 
Caleb-Hurshman, 
MaxKsyunz, 
MitchellGale, 
YANG-DB, 
adcharre, 
am-kinetica, 
asaharn, 
cheempz, 
driverpt, 
emreyalvac, 
jcreixell, 
jerrytfleung, 
rlankfo, 
shaochengwang, 
swar8080, 
thmshmm, 
yiyang5055, 
zpzhuSplunk
github-actions[bot] commented 1 month ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

alxbl commented 1 month ago

not stale, codeowners check should pass