search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.97k stars 2.3k forks source link

Verify on CI that localhost featuregate changes are copied across repositories #30793

Closed mx-psi closed 1 week ago

mx-psi commented 8 months ago 
          I'm wondering if there's a good way to enforce keeping this up to date `core`. There will be times they differ, but it should only be temporarily. There should be a PR opened for both repositories, one will just get merged before the other.

It could be a CI check that simply fails whenever a user changes the contents of these files, warning the user that core needs updated as well. A triager, approver, or maintainer could then come, confirm a PR is also opened against core, and then add some kind of skip label that ignores the check? Or just approve and merge it with the failing CI action knowing it's not an issue. If it's a CI action it would also need to be in core to make sure contrib stays up to date as well.

Otherwise we could add a CI action that simply compared file contents and fails when they don't match. This would be a bit more involved and would fail in unrelated PRs, which would be confusing.

I don't want to make it too complicated but speaking from experience, a comment at the top of a file is pretty easy to miss.

Originally posted by @crobert-1 in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30774#issuecomment-1910701943

github-actions[bot] commented 6 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

github-actions[bot] commented 4 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

github-actions[bot] commented 2 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

github-actions[bot] commented 1 week ago

This issue has been closed as inactive because it has been stale for 120 days with no activity.