Closed MichaelBriggs-Coralogix closed 2 months ago
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
I am not intricately familiar with this receiver but after a quick look I don't see any reason why this couldn't be done.
In terms of configuration, we could add a channels
parameter which is mutually exclusive with channel
, or we could just enhance channel
to be []string
(and continue allowing a single value). Do you seen any problems or have any reservations with this @pjanotti?
@MichaelBriggs-Coralogix I assume you are not using the other configuration options under channel
and we could guess that this is true for many other users of the windowseventlog
receiver. However, options like exclude_providers
, storage
(check-pointing) should be configurable per channel
, so it seems that we would have to support something like
receivers:
windowseventlog:
- channel: application
excluded_providers: [abc, xyz]
- channel: system
which is a breaking change. If we go with channels
custom configs like storage
can't be applied automatically to all specified channels.
It is almost easier to start with a new receiver just to support that convenience. It seems very low priority to me.
cc @djaglowski
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
@pjanotti @djaglowski
Correct, I haven't used any of the exclude_providers in my configuration. Though I suspect starting with the ability to do multiple channels with the same excluded_providers, and then creating secondary exporter configurations for channels that need different exclusions would still be preferable, and shouldn't require as large of a change.
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
This issue has been closed as inactive because it has been stale for 120 days with no activity.
Component(s)
receiver/windowseventlog
Is your feature request related to a problem? Please describe.
Not related to a problem, necessarily. This feature request is more of a quality of life improvement than a missing feature.
Describe the solution you'd like
When configuring the windowseventlog receiver, you have to specify a single channel. It's likely that we'll want to monitor multiple channels instead of just one. An option to allow configuration of multiple channels through a single receiver would be useful.
Describe alternatives you've considered
It's certainly possible to create multiple receivers and add each to your pipeline, but this might be better managed through a single receiver configuration.
Additional context
No response