search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.89k stars 2.27k forks source link

Refactor tail-sampling processor #31580

Open jpkrohling opened 6 months ago

jpkrohling commented 6 months ago

Component(s)

processor/tailsampling

Is your feature request related to a problem? Please describe.

The tail-sampling processor has been there for a few years now, and despite being relatively popular, it hasn't changed much over the years besides adding new policies. There are a few things I always wanted to do but didn't have the time or motivation, and it would be a good idea to list them here in case we have volunteers to work on them.

Describe the solution you'd like

Describe alternatives you've considered

No response

Additional context

No response

jpkrohling commented 6 months ago

cc @kentquirk

github-actions[bot] commented 6 months ago

Pinging code owners for processor/tailsampling: @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself.

kentquirk commented 6 months ago

Yes, AND, I also think that the binary keep/drop structure is a problem because it's not adequately composable if the probability of the decision matters to you. This proposal is related but I'm not sure yet if it actually applies.

jiekun commented 6 months ago

I'm interested in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/31584 if we could have more info / context / expectation :P

jpkrohling commented 4 months ago

I think this is also relevant for the discussion: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/25122

jpkrohling commented 4 months ago

Related: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/31498

github-actions[bot] commented 1 month ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.