search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.02k stars 2.34k forks source link

Ensuring Consistency between `service.instance.id` and `instanceId` in `opampextension` #32034

Open mike9421 opened 6 months ago

mike9421 commented 6 months ago

Component(s)

extension/opamp

Is your feature request related to a problem? Please describe.

While using opampextension, I found that when I wanted to query self-monitoring metrics and only knew the instanceId but not the service.instance.id, due to the inconsistency in their values, I was unable to query using instanceId.

If it were possible for instanceId and service.instance.id to be kept consistent as they are in opampsupervisor, then it would be convenient for me to query using the instanceId.

Describe the solution you'd like

"Considering the OpAMP and OTEL specifications, where instanceId must be a ULID and service.instance.id is recommended to use UUID, I suggest the following:

  1. service.instance.id uses ULID by default
  2. opampextension directly reuses service.instance.id without setting the instanceId configuration item.

Describe alternatives you've considered

No response

Additional context

No response

github-actions[bot] commented 6 months ago

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

evan-bradley commented 6 months ago

Thanks for the detailed write-up. I will have to think over the solution more, but I think this is valid.

tigrannajaryan commented 6 months ago

FYI, we may move from ULID to UUID in opamp too: https://github.com/open-telemetry/opamp-spec/pull/186

github-actions[bot] commented 4 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

mike9421 commented 2 months ago

Information can be synchronized at https://github.com/open-telemetry/opamp-spec/pull/186

github-actions[bot] commented 2 weeks ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.