Open mike9421 opened 3 months ago
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
Thanks for opening this. You're right, this is currently an issue due to the way the Collector's underlying conf library merges lists. A potential fix in the Collector has been documented here: https://github.com/open-telemetry/opentelemetry-collector/issues/8754. For now, I have an open PR that will introduce a fix for the Supervisor in the meantime: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/31641
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
Component(s)
cmd/opampsupervisor
What happened?
Description
When I delivered the remote configuration through the OpAMP sample server, I found that the
extension
in the final configuration of OTEL was cleared, leaving onlyhealth_check
.Steps to Reproduce
Expected Result
The extension component I added is not cleared, at most
health_check
is addedActual Result
The extension component I added was cleared
Collector version
all
Environment information
OS: Darwin Compiler: go 1.21
OpenTelemetry Collector configuration
Log output
No response
Additional context
I know that the extensions configuration item is overwritten in this code. The fundamental reason is that
koanf
cannot parseextensions
into key-value form, so the previous value will be overwritten. I think we can solve this problem by adding configuration items toextensions
instead of executingkoanf.merge
directly.