search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.09k stars 2.38k forks source link

[receiver/googlecloudspanner] Test TestItemCardinalityFilter_Filter fails intermittently on Windows runs #32397

Open crobert-1 opened 7 months ago

crobert-1 commented 7 months ago

Component(s)

receiver/googlecloudspanner

Describe the issue you're reporting

CI/CD failure link

Failure output:

Running target 'test' in module 'receiver/googlecloudspannerreceiver' as part of group 'receiver-1'
C:/mingw64/bin/make --no-print-directory -C receiver/googlecloudspannerreceiver test
D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum --rerun-fails=1 --packages="./..." -- -race -timeout [30](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8694703823/job/23844185019?pr=32176#step:7:31)0s -parallel 4 --tags=""
✓  internal/filterfactory (cached)
✓  internal/metadata (cached)
✖  internal/filter (434ms)
✓  internal/datasource (2.156s)
✓  . (5.051s)
✓  internal/metadataconfig (1.778s)
✓  internal/metadataparser (1.744s)
✓  internal/statsreader (1.891s)

DONE 288 tests, 1 skipped, 1 failure in 13.253s

✖  internal/filter (888ms)

=== Skipped
=== SKIP: internal/statsreader TestStatsReaders_Read (0.00s)
    statsreaders_mockedspanner_test.go:123: Flaky test - See https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/6[31](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8694703823/job/23844185019?pr=32176#step:7:32)8

=== Failed
=== FAIL: internal/filter TestItemCardinalityFilter_Filter (0.10s)
    logger.go:146: 2024-04-15T19:22:05.611Z DEBUG   Added item to cache {"seriesKey": "key1", "timestamp": "2021-10-13T20:30:00.000Z"}
    logger.go:146: 2024-04-15T19:22:05.660Z DEBUG   Added item to cache {"seriesKey": "key2", "timestamp": "2021-10-13T20:30:00.000Z"}
    logger.go:146: 2024-04-15T19:22:05.661Z DEBUG   Skip item   {"seriesKey": "key3", "timestamp": "2021-10-13T20:30:00.000Z"}
    logger.go:146: 2024-04-15T19:22:05.661Z DEBUG   Added item to cache {"seriesKey": "key5", "timestamp": "2021-10-13T20:30:05.000Z"}
    logger.go:146: 2024-04-15T19:22:05.661Z DEBUG   Added item to cache {"seriesKey": "key4", "timestamp": "2021-10-13T20:30:10.000Z"}
    logger.go:146: 2024-04-15T19:22:05.661Z DEBUG   Skip item   {"seriesKey": "key6", "timestamp": "2021-10-13T20:30:10.000Z"}
    logger.go:146: 2024-04-15T19:22:05.662Z DEBUG   Added item to cache {"seriesKey": "key3", "timestamp": "2021-10-13T20:30:20.000Z"}
    logger.go:146: 2024-04-15T19:22:05.662Z DEBUG   Skip item   {"seriesKey": "key6", "timestamp": "2021-10-13T20:30:20.000Z"}
    itemcardinality_test.go:1[43](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8694703823/job/23844185019?pr=32176#step:7:44): 
            Error Trace:    D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/googlecloudspannerreceiver/internal/filter/itemcardinality_test.go:143
            Error:          Not equal: 
                            expected: 0
                            actual  : 1
            Test:           TestItemCardinalityFilter_Filter
    logger.go:1[46](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8694703823/job/23844185019?pr=32176#step:7:47): 2024-04-15T19:22:05.716Z DEBUG   Added item to cache {"seriesKey": "key3", "timestamp": "2021-10-13T20:30:20.000Z"}
    logger.go:146: 2024-04-15T19:22:05.716Z DEBUG   Added item to cache {"seriesKey": "key6", "timestamp": "2021-10-13T20:30:20.000Z"}

DONE 2 runs, 289 tests, 1 skipped, 1 failure in 15.777s
make[2]: *** [../../Makefile.Common:126: test] Error 1
make[1]: *** [Makefile:165: receiver/googlecloudspannerreceiver] Error 2
github-actions[bot] commented 7 months ago

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] commented 5 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

github-actions[bot] commented 3 months ago

This issue has been closed as inactive because it has been stale for 120 days with no activity.

pjanotti commented 1 month ago

Recent hit https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10908442891/job/30274434215#step:8:228

=== FAIL: internal/filter TestItemCardinalityFilter_Filter (0.05s)
    logger.go:146: 2024-09-17T18:06:05.980Z DEBUG   Added item to cache {"seriesKey": "key1", "timestamp": "2021-10-13T20:30:00.000Z"}
    logger.go:146: 2024-09-17T18:06:06.033Z DEBUG   Added item to cache {"seriesKey": "key2", "timestamp": "2021-10-13T20:30:00.000Z"}
    logger.go:146: 2024-09-17T18:06:06.033Z DEBUG   Skip item   {"seriesKey": "key3", "timestamp": "2021-10-13T20:30:00.000Z"}
    logger.go:146: 2024-09-17T18:06:06.033Z DEBUG   Added item to cache {"seriesKey": "key1", "timestamp": "2021-10-13T20:30:05.000Z"}
    logger.go:146: 2024-09-17T18:06:06.034Z DEBUG   Added item to cache {"seriesKey": "key5", "timestamp": "2021-10-13T20:30:05.000Z"}
    logger.go:146: 2024-09-17T18:06:06.034Z DEBUG   Added item to cache {"seriesKey": "key4", "timestamp": "2021-10-13T20:30:10.000Z"}
    logger.go:146: 2024-09-17T18:06:06.034Z DEBUG   Added item to cache {"seriesKey": "key6", "timestamp": "2021-10-13T20:30:10.000Z"}
    testhelpers_test.go:46: 
            Error Trace:    D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/googlecloudspannerreceiver/internal/filter/testhelpers_test.go:46
                                        D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/googlecloudspannerreceiver/internal/filter/itemcardinality_test.go:136
            Error:          Not equal: 
                            expected: 7
                            actual  : 8
            Test:           TestItemCardinalityFilter_Filter

DONE 2 runs, 289 tests, 1 skipped, 1 failure in 56.590s
pjanotti commented 1 month ago

Another one https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10937096708/job/30362176527#step:8:232

=== Failed
make[1]: *** [Makefile:187: receiver/googlecloudspannerreceiver] Error 2
=== FAIL: internal/filter TestItemCardinalityFilter_Filter (0.05s)
make[1]: *** Waiting for unfinished jobs....
    logger.go:146: 2024-09-19T08:24:10.355Z DEBUG   Added item to cache {"seriesKey": "key1", "timestamp": "2021-10-13T20:30:00.000Z"}
    logger.go:146: 2024-09-19T08:24:10.408Z DEBUG   Added item to cache {"seriesKey": "key2", "timestamp": "2021-10-13T20:30:00.000Z"}
    logger.go:146: 2024-09-19T08:24:10.408Z DEBUG   Skip item   {"seriesKey": "key3", "timestamp": "2021-10-13T20:30:00.000Z"}
    logger.go:146: 2024-09-19T08:24:10.408Z DEBUG   Added item to cache {"seriesKey": "key1", "timestamp": "2021-10-13T20:30:05.000Z"}
    logger.go:146: 2024-09-19T08:24:10.408Z DEBUG   Added item to cache {"seriesKey": "key5", "timestamp": "2021-10-13T20:30:05.000Z"}
    logger.go:146: 2024-09-19T08:24:10.408Z DEBUG   Added item to cache {"seriesKey": "key4", "timestamp": "2021-10-13T20:30:10.000Z"}
    logger.go:146: 2024-09-19T08:24:10.408Z DEBUG   Added item to cache {"seriesKey": "key6", "timestamp": "2021-10-13T20:30:10.000Z"}
    testhelpers_test.go:46: 
            Error Trace:    D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/googlecloudspannerreceiver/internal/filter/testhelpers_test.go:46
                                        D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/googlecloudspannerreceiver/internal/filter/itemcardinality_test.go:136
            Error:          Not equal: 
                            expected: 7
                            actual  : 8
            Test:           TestItemCardinalityFilter_Filter
crobert-1 commented 1 month ago

The failing tests are now being skipped on Windows until someone has an opportunity to investigate and fix.

pjanotti commented 2 weeks ago

Related test failure

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11632160146/job/32394688426#step:8:288

cc'ing code owners since the component was recently re-instated (see #35998) @dashpole @dsimil @KiranmayiB @harishbohara11

=== FAIL: internal/filter TestItemCardinalityFilter_IncludeItem (0.05s)
    logger.go:146: 2024-11-01T15:56:18.350Z DEBUG   Added item to cache {"seriesKey": "key1", "timestamp": "2024-11-01T15:56:18.350Z"}
    logger.go:146: 2024-11-01T15:56:18.402Z DEBUG   Skip item   {"seriesKey": "key1", "timestamp": "2024-11-01T15:56:18.350Z"}
    itemcardinality_test.go:262: 
            Error Trace:    D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/googlecloudspannerreceiver/internal/filter/itemcardinality_test.go:262
            Error:          Should be true
            Test:           TestItemCardinalityFilter_IncludeItem
    logger.go:146: 2024-11-01T15:56:18.402Z DEBUG   Skip item   {"seriesKey": "key2", "timestamp": "2024-11-01T15:56:18.350Z"}

=== FAIL: internal/filter TestItemCardinalityFilter_IncludeItem (re-run 1) (0.08s)
    logger.go:146: 2024-11-01T15:56:38.993Z DEBUG   Added item to cache {"seriesKey": "key1", "timestamp": "2024-11-01T15:56:38.993Z"}
    logger.go:146: 2024-11-01T15:56:39.069Z DEBUG   Skip item   {"seriesKey": "key1", "timestamp": "2024-11-01T15:56:38.993Z"}
    itemcardinality_test.go:262: 
            Error Trace:    D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/googlecloudspannerreceiver/internal/filter/itemcardinality_test.go:262
            Error:          Should be true
            Test:           TestItemCardinalityFilter_IncludeItem
    logger.go:146: 2024-11-01T15:56:39.069Z DEBUG   Skip item   {"seriesKey": "key2", "timestamp": "2024-11-01T15:56:38.993Z"}
pjanotti commented 15 hours ago

Another hits:

Same as the above messages.