search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.71k stars 2.14k forks source link

[exporter/elasticsearch] Support both v7 and v8 elasticsearch clients and default to v8 #32454

Open carsonip opened 2 months ago

carsonip commented 2 months ago

Component(s)

exporter/elasticsearch

Is your feature request related to a problem? Please describe.

Currently elasticsearch exporter uses go-elasticsearch v7 because of the "forward compatibility" described in https://github.com/elastic/go-elasticsearch?tab=readme-ov-file#elasticsearch and raised in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/16310. However, this means that v8 stack users are also forced to use go-elasticsearch v7 as mentioned in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/29689. v8 go-elasticsearch client gets the bugfixes and features that may not be available in v7 go-elasticsearch client. Elasticsearch exporter should support both v7 and v8 elasticsearch client, and ideally default to v8 (which may be a breaking change).

Describe the solution you'd like

Describe alternatives you've considered

No response

Additional context

Related to https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/32378

github-actions[bot] commented 2 months ago

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

JaredTan95 commented 2 months ago

Agree, this upgrade has been mentioned many times and I think it is a necessary upgrade

github-actions[bot] commented 1 week ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

carsonip commented 1 week ago

Still relevant, and this should be ready to implement as elasticsearchexporter is now using go-docappender