search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.07k stars 2.37k forks source link

How should we handle imports of time/tzdata by dependencies? #32688

Open djaglowski opened 6 months ago

djaglowski commented 6 months ago

Component(s)

No response

Describe the issue you're reporting

This relates to discussion https://github.com/open-telemetry/opentelemetry-collector/issues/9991, in which there seems to be consensus that we will follow the official guidance from time/tzdata which states: This package should normally be imported by a program's main package, not by a library. Libraries normally shouldn't decide whether to include the timezone database in a program.

As noted in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/32506, we are currently pulling in a dependency in one of our components which imports the database. This effectively makes the decision for all of contrib that it will be included in the distro. I believe we should discourage this somehow.

Should we make a policy that components which import the database cannot be included in contrib?

github-actions[bot] commented 4 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

github-actions[bot] commented 2 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.