search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.95k stars 2.29k forks source link

[receiver/hostmetrics] Remove shared from system.memory.state values #32712

Open ChrsMark opened 5 months ago

ChrsMark commented 5 months ago

Component(s)

receiver/hostmetrics

Describe the issue you're reporting

If https://github.com/open-telemetry/semantic-conventions/pull/933 is merged we will need to change the receiver implementation accordingly.

ref: https://github.com/open-telemetry/semantic-conventions/issues/522

github-actions[bot] commented 5 months ago

Pinging code owners:

%s See Adding Labels via Comments if you do not have permissions to add labels yourself.

crobert-1 commented 5 months ago

Hopefully not taking this out of context, but a code owner's response on another issue seems to agree with this decision as well.

Removing needs triage.

github-actions[bot] commented 3 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

rogercoll commented 3 months ago

Still important for v1. Once slab memory is available in the semantic conventions, we could implement the shared + slab removal under the same feature gate.

github-actions[bot] commented 1 month ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.