open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.85k stars 2.23k forks source link

Preserve processor order in testbed Yaml config creator #33003

Open swamisriman opened 3 months ago

swamisriman commented 3 months ago

Component(s)

testbed

Is your feature request related to a problem? Please describe.

In testbed scenarios.go, there is a function createConfigYaml(...) (ref) to get yaml config from given parameters. As it takes the processor argument as a map, the processor order is not maintained.

This way, it's not possible to test scenarios where the processor order is important.

Describe the solution you'd like

Would be better if the function takes processors argument as an ordered data structure(say list). or The function may also take an additional argument with the list of processors (in the required order)

Describe alternatives you've considered

An alternate solution would be to get the config generated and then update the processors list to the required order

Additional context

No response

github-actions[bot] commented 3 months ago

Pinging code owners:

crobert-1 commented 3 months ago

Good point, it should be ordered 👍 Thanks for calling this out!

github-actions[bot] commented 1 month ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.