Open vjsamuel opened 1 month ago
@jpkrohling
Pinging code owners:
connector/spanmetrics: @portertech @Frapschen
See Adding Labels via Comments if you do not have permissions to add labels yourself.
similar to service graph connector
Can you give more context about the relate work of graph connector(issue or PR)?
as you can see here, the metrics are neatly namespaced with signal type followed by connector name and finally the actual metric.
I agree that we need to add a component identification to the metrics name.
It's a big breaking change, we need to keep both traces_span_metrics_calls_total
and calls_total
for one or two releases and then remove calls_total
WDYT @dmitryax
Component(s)
connector/spanmetrics
Is your feature request related to a problem? Please describe.
span metrics connector today establishes metric names as
calls_total
andduration
which lacks proper namespacingDescribe the solution you'd like
similar to service graph connector if we could do:
traces_spanmetrics_.*
for the metric names it would ensure consistency across all connectorsDescribe alternatives you've considered
No response
Additional context
This would also help use the grafana service graph view when using the open telemetry collector directly.