open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.73k stars 2.16k forks source link

Establish consistency in metric naming for span metrics connector #33227

Open vjsamuel opened 1 month ago

vjsamuel commented 1 month ago

Component(s)

connector/spanmetrics

Is your feature request related to a problem? Please describe.

span metrics connector today establishes metric names as calls_total and duration which lacks proper namespacing

Describe the solution you'd like

similar to service graph connector if we could do: traces_spanmetrics_.* for the metric names it would ensure consistency across all connectors

Describe alternatives you've considered

No response

Additional context

This would also help use the grafana service graph view when using the open telemetry collector directly.

vjsamuel commented 1 month ago

@jpkrohling

github-actions[bot] commented 1 month ago

Pinging code owners:

Frapschen commented 1 month ago

similar to service graph connector

Can you give more context about the relate work of graph connector(issue or PR)?

vjsamuel commented 1 month ago

https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/connector/servicegraphconnector#metrics

as you can see here, the metrics are neatly namespaced with signal type followed by connector name and finally the actual metric.

gouthamve commented 2 weeks ago

Also see https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/32818

Frapschen commented 3 days ago

I agree that we need to add a component identification to the metrics name.

It's a big breaking change, we need to keep both traces_span_metrics_calls_total and calls_total for one or two releases and then remove calls_total WDYT @dmitryax