search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.72k stars 2.16k forks source link

[exporter/datasetexporter] Upgrade to dataset-go v0.19.0 #33675

Closed martin-majlis-s1 closed 1 week ago

martin-majlis-s1 commented 1 week ago

Description: This PR is upgrading dataset-go to version v0.19.0 - https://github.com/scalyr/dataset-go/releases/tag/v0.19.0

This PR is also fixing:

Link to tracking Issue: #33498, #32533, #33675

Testing: Unit tests and integration tests.

Documentation:

fixes #32533

martin-majlis-s1 commented 1 week ago

There is failing check - https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/9598696641/job/26470817018?pr=33675#step:13:1

Generated code is out of date, please run "make genotelcontribcol" and commit the changes in this PR.

However, when I run that command:

 make genotelcontribcol
/foo/opentelemetry-collector-contrib/.tools/builder --skip-compilation --config cmd/otelcontribcol/builder-config.yaml --output-path cmd/otelcontribcol
Flag --output-path has been deprecated, use config distribution::output_path
2024-06-20T16:08:09.897+0200    INFO    internal/command.go:125 OpenTelemetry Collector Builder {"version": "", "date": "unknown"}
2024-06-20T16:08:09.899+0200    INFO    internal/command.go:161 Using config file       {"path": "cmd/otelcontribcol/builder-config.yaml"}
2024-06-20T16:08:09.899+0200    INFO    builder/config.go:141   Using go        {"go-executable": "/opt/homebrew/bin/go"}
2024-06-20T16:08:09.905+0200    INFO    builder/main.go:100     Sources created {"path": "cmd/otelcontribcol"}
2024-06-20T16:08:10.612+0200    INFO    builder/main.go:191     Getting go modules
2024-06-20T16:08:10.996+0200    INFO    builder/main.go:107     Generating source codes only, the distribution will not be compiled.
/Library/Developer/CommandLineTools/usr/bin/make --no-print-directory -C cmd/otelcontribcol fmt
Makefile:4: warning: overriding commands for target `lint'
../../Makefile.Common:199: warning: ignoring old commands for target `lint'
gofmt  -w -s ./
/foo/opentelemetry-collector-contrib/.tools/goimports -w  -local github.com/open-telemetry/opentelemetry-collector-contrib ./

And based on the git status, there are no changes:

On branch datasetexporter-update-to-0.19.0
Your branch is up to date with 'origin/datasetexporter-update-to-0.19.0'.

nothing to commit, working tree clean

Or git diff

git diff | wc
      0       0       0
martin-majlis-s1 commented 1 week ago

Small comment on expanding the changelog entry, besides that, LGTM.

Thanks.

I have added those details. My expectation was, that changelog is meant for users - and they do not care whether integration tests are now running when in the past they have been skipped.