open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.72k stars 2.16k forks source link

[clickhouse/exporter] Update create schema config option #33694

Closed SpencerTorres closed 1 week ago

SpencerTorres commented 1 week ago

EXTRACTED FROM #33614

DEPENDS ON #33693

Description:

A follow-up to #32282 that changes create_schema from *bool to bool, while also properly using the default config / factory.

Testing:

dmitryax commented 1 week ago

Please rebase. I'm not sure why it depends on https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33693

SpencerTorres commented 1 week ago

Rebased. Need to fix the next PR but this one should be good now 👍

crobert-1 commented 1 week ago

Failing test is unrelated, I've opened #33715 to address the failure.