open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.73k stars 2.16k forks source link

New component: Valkey receiver #33787

Open rogercoll opened 1 week ago

rogercoll commented 1 week ago

The purpose and use-cases of the new component

Valkey is a high-performance data structure server that primarily serves key/value workloads. It supports a wide range of native structures and an extensible plugin system for adding new data structures and access patterns.

Repository: https://github.com/valkey-io/valkey

The component should behave as the current redis receiver. Actually, the redis receiver is currently being used in the OpenTelemetry demo to extract metrics from a valkey instance, see: https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/otelcollector/otelcol-config.yml#L17 The OpenTelemetry demo uses the redis receiver as a short term solution, but the end goal would be to use a valkey specific one in case their APIs change. They are two different products, so we expect their functionalities may diverge over time.

Implementation proposal:

Example configuration for the component

valkey:
  endpoint: "localhost:6379"
  username: "test"
  password: "test"
  collection_interval: 10s
  tls:
    insecure: true

Configuration example source.

Telemetry data types supported

Is this a vendor-specific component?

Code Owner(s)

@rogercoll

Sponsor (optional)

No response

Additional context

I proposed myself as a codeowner, but I am absolutely open to any suggestion. @dmitryax, @hughesjj as being codowners of the current redis receiver, would you also like to continue in this role for the valkey one?

As discussed in the SIG meeting, @dmitryax would you be able to sponsor this new component?

andrzej-stencel commented 1 week ago

@dmitryax would you be up for sponsoring this?