open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.73k stars 2.16k forks source link

Update module github.com/prometheus/prometheus to v0.53.0 causes test failures #33889

Closed codeboten closed 10 hours ago

codeboten commented 5 days ago

Component(s)

receiver/prometheus

Describe the issue you're reporting

The upgrade causes the following test failures:


=== Failed
=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_off/target1/target1 (0.00s)
    metrics_receiver_helper_test.go:446: 
            Error Trace:    /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:446
                                        /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:398
            Error:          Should be true
            Test:           TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_off/target1/target1
            Messages:       expected metric 'test_mixed_histogram' is not present

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_off/target1 (0.00s)

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_off (6.51s)

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_on/target1/target1 (0.00s)
    metrics_receiver_helper_test.go:446: 
            Error Trace:    /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:446
                                        /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:398
            Error:          Should be true
            Test:           TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_on/target1/target1
            Messages:       expected metric 'test_native_histogram' is not present

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_on/target1 (0.00s)

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_on (6.51s)

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf (26.04s)

=== FAIL: . TestStaleExponentialHistogram/target1/target11 (0.00s)
    metrics_receiver_helper_test.go:446: 
            Error Trace:    /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:446
                                        /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:398
            Error:          Should be true
            Test:           TestStaleExponentialHistogram/target1/target11
            Messages:       expected metric 'test_native_histogram' is not present

=== FAIL: . TestStaleExponentialHistogram/target1 (0.00s)

=== FAIL: . TestStaleExponentialHistogram (7.51s)

=== FAIL: . TestFloatCounterHistogram/target1 (0.00s)
    metrics_receiver_helper_test.go:313: 
            Error Trace:    /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:313
                                        /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:253
                                        /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:702
            Error:          Not equal: 
                            expected: 0
=== FAIL: . TestStaleExponentialHistogram (re-run 1) (7.51s)

=== FAIL: . TestFloatCounterHistogram/target1 (re-run 1) (0.00s)
    metrics_receiver_helper_test.go:313: 
            Error Trace:    /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:313
                                        /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:253
                                        /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:702
            Error:          Not equal: 
                            expected: 0
                            actual  : 1
            Test:           TestFloatCounterHistogram/target1
    metrics_receiver_helper_test.go:205: 
            Error Trace:    /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:205
                                        /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_protobuf_test.go:600
                                        /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:704
            Error:          "1" is not less than or equal to "0"
            Test:           TestFloatCounterHistogram/target1
            Messages:       want at least 1 valid scrapes, but got 0

=== FAIL: . TestFloatCounterHistogram (re-run 1) (6.52s)
github-actions[bot] commented 5 days ago

Pinging code owners:

codeboten commented 5 days ago

Looks like a change in the prom library https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33890

dashpole commented 10 hours ago

thanks for fixing @codeboten!