[exporter/datadog] Error returned from authAPI.Validate is not propagated

[RonFed]

Component(s)

exporter/datadog

What happened?

Description

The error returned from Validate is not returned. I'm not sure if this is intentional or not. From debugging this and entering an invalid API key I see an error of 403 forbidden is returned but only logged. https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/6ff2a8a5ec508d8b0833836089721a4a1a0b8651/exporter/datadogexporter/internal/clientutil/api.go#L39-L53

Collector version

v0.104.0

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

[github-actions[bot]]

Pinging code owners:

• exporter/datadog: @mx-psi @dineshg13 @liustanley @songy23 @mackjmr @ankitpatel96

  See Adding Labels via Comments if you do not have permissions to add labels yourself.

[mx-psi]

@RonFed This is intentional and mimics the behavior of the Datadog Agent. To propagate the error you can set api::fail_on_invalid_key to true. Let me know if that is what you were looking for.

[RonFed]

@mx-psi I have tried this config but it still causes the error to not get propagated, since the function above is not returning it, it doesn't get sent in the error channel and the check for the configuration you proposed is not catching it in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/0385b21f231acaa0daa8c62a095510ebc4479960/exporter/datadogexporter/traces_exporter.go#L70-L90

[mx-psi]

I am taking a look at this. I filed #33944 but I am a bit confused as to why the endpoint would be returning 403 for something that should not need authentication, so I am checking internally as well :)

[mx-psi]

This will be fixed in v0.105.0, thanks for taking the time to report it!