open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.05k stars 2.36k forks source link

[exporter/splunkhecexporter] Support separate metric index for hec exporter #35039

Closed spiffyy99 closed 1 week ago

spiffyy99 commented 1 month ago

Component(s)

exporter/splunkhec

Is your feature request related to a problem? Please describe.

Users of splunkhecexporter may be sending both logs and metrics data at the same time, so the config should provide a separate default metrics index to support this, since metrics and logs indexes support different data.

Describe the solution you'd like

To avoid regressions in existing clients, metrics index can be configured as such:

Describe alternatives you've considered

No response

Additional context

No response

github-actions[bot] commented 1 month ago

Pinging code owners:

atoulme commented 1 month ago

It doesn't look to me like we would need a UseMetricsIndex field. We can just check if MetricsIndex is set.

If MetricsIndex is set, we use it when converting metrics to splunk events. If it is not set, we should default back to the Index config field to preserve the current behavior.

spiffyy99 commented 1 month ago

It doesn't look to me like we would need a UseMetricsIndex field. We can just check if MetricsIndex is set.

If MetricsIndex is set, we use it when converting metrics to splunk events. If it is not set, we should default back to the Index config field to preserve the current behavior.

good point. that's fine as well.

crobert-1 commented 1 month ago

Removing needs triaged based on response from code owner.

atoulme commented 1 week ago

@spiffyy99 are you still working on this?

spiffyy99 commented 1 week ago

No, we decided to go with a different approach. Lets close this out.