open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.06k stars 2.36k forks source link

New component: Faro exporter #35319

Open mar4uk opened 1 month ago

mar4uk commented 1 month ago

The purpose and use-cases of the new component

The purpose of this component would be to export telemetry to the Grafana Cloud Frontend Observability Collector

Example configuration for the component

exporters:
  faro:
    endpoint: https://faro-collector-example.grafana.net/collect/app-key-example

Telemetry data types supported

Logs Traces

Is this a vendor-specific component?

Code Owner(s)

mar4uk, rlankfo

Sponsor (optional)

No response

Additional context

No response

atoulme commented 1 month ago

Reviewed quickly during the SIG meeting on 9/24: this is not a vendor-specific component if it targets an open source solution in my opinion. @jpkrohling would you please review?

mar4uk commented 1 month ago

Hey @atoulme! Thank you for reviewing! Faro exporter is a vendor-specific (Grafana) component because the target is the Faro collector whose code is not an open source

atoulme commented 3 weeks ago

Understood. @mar4uk, we have some new rules where we try to limit vendor-specific to one per type (exporter, processor, receiver, connector). See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#vendor-specific-components

This might mean this component would be called "grafanaexporter", exporting to Faro.

mar4uk commented 3 weeks ago

Thank you for clarifications! Got it. Currently, there are no grafana-specific exporters in the repo, which means rules are not violated. I will name it grafanaexporter as you proposed 👍