open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.98k stars 2.31k forks source link

datadog receiver is missing container id #35345

Closed povilasv closed 1 week ago

povilasv commented 2 weeks ago

Component(s)

receiver/datadog

Is your feature request related to a problem? Please describe.

Looks like we are missing container id in DD receiver, and this makes some screens in DD don't work (when received and exported thru collector)

Describe the solution you'd like

I've got details of some request:

Sending request: PUT v0.5/traces {'Datadog-Meta-Lang': 'python', 'Datadog-Meta-Lang-Version': '3.10.14', 'Datadog-Meta-Lang-Interpreter': 'CPython', 'Datadog-Meta-Tracer-Version': '2.7.2', 'Datadog-Client-Computed-Top-Level': 'yes', 'Datadog-Container-Id': '7d0f62eb396bd016230ebc53d525bd6bc9ce734894fcf70b39f268b62001a79d', 'Datadog-Entity-ID': 'cid-7d0f62eb396bd016230ebc53d525bd6bc9ce734894fcf70b39f268b62001a79d', 'Content-Type': 'application/msgpack', 'X-Datadog-Trace-Count': '1'}

Looks like Datadog-Container-Id is the header. I've looked thru exporter code and it should pick up container id from semconv, so in theory should work.

Describe alternatives you've considered

No response

Additional context

No response

github-actions[bot] commented 2 weeks ago

Pinging code owners: