open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
2.92k stars 2.28k forks source link

Support virtual node with zipkin shared span ID #35358

Open EOjeah opened 3 hours ago

EOjeah commented 3 hours ago

Component(s)

connector/servicegraph

Is your feature request related to a problem? Please describe.

A way to configure the connector to form a virtual node from zipkin model with shared span ID.

Describe the solution you'd like

A way to configure the connector to work with systems that use zipkin context propagation where both client and server spans share the same span ID

Describe alternatives you've considered

No response

Additional context

Currently, service graph connector supports otel context proration for client, server architecture. This is when the server is linked to the client by the server having the parentSpanID set to the client span ID. https://opentelemetry.io/docs/concepts/context-propagation/#context

Can this connector also support RPC with zipkin model where client and server share the same span ID?

Fully aware of this statement but Zipkin has the concept of shared IDs https://opentelemetry.io/docs/specs/otel/context/api-propagators/#b3-extract

MUST NOT reuse X-B3-SpanId as the id for the server-side span.

github-actions[bot] commented 3 hours ago

Pinging code owners: