[pkg/stanza] Windows input operator leaks remote session handle

kuiperda commented 4 hours ago

Component(s)

pkg/stanza

What happened?

Description

@pjanotti noticed this here (#35520)

Steps to Reproduce

See the comment above. Since Subscription::Close does not close the remote session handle, it is leaked. This will happen when the operator resubscribes due to the remote host restarting, for example.

Expected Result

The remote session handle should be closed properly so it does not get leaked.

Actual Result

Collector version

v0.110.0

Environment information

N/A

OpenTelemetry Collector configuration

N/A

Log output

N/A

Additional context

N/A

github-actions[bot] commented 4 hours ago

Pinging code owners:

pkg/stanza: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

VihasMakwana commented 4 hours ago

Based on https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/35520#issuecomment-2391437750, it seems as @kuiperda wouldn't have time to work on this.

I will have a crack at this though. @djaglowski can you assign this to me?

crobert-1 commented 1 hour ago

Removing needs triage as a triager pointed out this issue.

open-telemetry / opentelemetry-collector-contrib