open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.05k stars 2.36k forks source link

Add Timezone Info in Docker Image #35901

Open joker-star-l opened 1 week ago

joker-star-l commented 1 week ago

Component(s)

exporter/doris

Describe the issue you're reporting

The doris exporter needs timezone info to handle different timezone. But it is not in the current docker image. Can I add this to the dockerfile?

docker

mx-psi commented 1 week ago

Duplicate of open-telemetry/opentelemetry-collector/issues/9991, if you file a PR on opentelemetry-collector-releases modifying this https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/Dockerfile and the rest of the Dockerfiles I think we can reopen the discussion

joker-star-l commented 1 week ago

Duplicate of open-telemetry/opentelemetry-collector/issues/9991, if you file a PR on opentelemetry-collector-releases modifying this https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/Dockerfile and the rest of the Dockerfiles I think we can reopen the discussion

Thank you!. I have read the issues you mentioned. As these said, tzdata changes frequently, maybe I can solve this problem by specifying in the doris exporter documentation that the host tzdata should be mounted when using docker.

mx-psi commented 1 week ago

I am personally not against having a copy on the Docker image and allowing the user to override it in case it is outdated