open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.03k stars 2.34k forks source link

testar fails on CRLF #35951

Closed sh0rez closed 19 hours ago

sh0rez commented 1 day ago

Component(s)

processor/deltatocumulative

What happened?

Description

Git on Windows turns LF into CRLF.

golang.org/x/tools/txtar, which powers internal/testar does not handle that.

An issue and CL for that appear inactive: https://github.com/golang/go/issues/59264

Steps to Reproduce

Check out .test files on windows

Expected Result

Tests passes

Actual Result

Test fails with file not found, as txtar does not parse

Collector version

78905b80ab15c494c66f3347455f2fe60137808a

Environment information

Environment

OS: (e.g., "Ubuntu 20.04") Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

songy23 commented 19 hours ago

Dup of https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/35876