open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.04k stars 2.34k forks source link

[processor/k8sattributes] Add support for profiles signal #35983

Open mx-psi opened 4 days ago

mx-psi commented 4 days ago

Component(s)

processor/k8sattributes

Describe the issue you're reporting

This processor would be useful for testing and validation of the experimental profiling signal, and to replace some functionality available in the eBPF Agent.

As inspiration for how to add support this PR can be used: open-telemetry/opentelemetry-collector/pull/11071 (there is no processor with support as of the writing of this issue)

Example of configuration using profiles (needs service.profilesSupport feature gate to be enabled):

receivers:
  otlp:
    protocols:
      grpc:
exporters:
  otlp:
    endpoint: ${OTLP_ENDPOINT}
service:
  pipelines:
    profiles:
      receivers: [otlp]
      exporters: [otlp]
github-actions[bot] commented 4 days ago

Pinging code owners:

haoqixu commented 4 days ago

The package go.opentelemetry.io/collector/processor/processorhelper lacks profile support. Should we extend the *helper package or implement the helper struct/functions in a separate package? The same issue exists for receiverhelper and exporterhelper.

mx-psi commented 3 days ago

processorhelper only handles telemetry. Since we are going to rework that API, I would prefer to leave telemetry out of the picture for now (same thing we did for receivers, see https://github.com/open-telemetry/opentelemetry-collector/pull/11071#discussion_r1751780801). For exporters, we have a dedicated module for profiles

haoqixu commented 3 days ago

processorhelper only handles telemetry. Since we are going to rework that API, I would prefer to leave telemetry out of the picture for now (same thing we did for receivers, see open-telemetry/opentelemetry-collector#11071 (comment)). For exporters, we have a dedicated module for profiles

Thank you for the information. I will submit a PR soon.