search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.09k stars 2.38k forks source link

[release] make update-otel fails with minimal details #36219

Open djaglowski opened 1 week ago

djaglowski commented 1 week ago

Component(s)

No response

Describe the issue you're reporting

In step 1 of the contrib release process, the following error occurs:

> make update-otel OTEL_VERSION=v0.113.0 OTEL_STABLE_VERSION=v1.19.0
...
2024-11-05T16:01:09.936-0500    INFO    builder/config.go:159   Using go        {"go-executable": "/opt/homebrew/bin/go"}
2024-11-05T16:01:09.938-0500    INFO    builder/main.go:100     Sources created {"path": "cmd/oteltestbedcol"}
2024-11-05T16:01:10.212-0500    INFO    builder/main.go:191     Getting go modules
2024-11-05T16:01:12.202-0500    INFO    builder/main.go:107     Generating source codes only, the distribution will not be compiled.
cd ./cmd/oteltestbedcol && GO111MODULE=on CGO_ENABLED=0 go build -trimpath -o ../../bin/oteltestbedcol_darwin_arm64 \
                -tags "" .
main module (github.com/open-telemetry/opentelemetry-collector-contrib) does not contain package github.com/open-telemetry/opentelemetry-collector-contrib/cmd/oteltestbedcol
make[1]: *** [oteltestbedcol] Error 1
make: *** [update-otel] Error 2
djaglowski commented 1 week ago

This was due to having manually created a go work space in order to validate an earlier part of the release process, but not having deleted the workspace files. Ideally the process would not allow for manual mistake like this.

mowies commented 1 week ago

Are we already checking if the workdir is clean and without any uncommitted changes before this? That would be a low hanging fruit probably.