search

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.11k stars 2.39k forks source link

fix: support indexing more types #36401

Closed znd4 closed 6 days ago

znd4 commented 1 week ago

Description

Bugfix: support indexing more types

[!IMPORTANT]
I'm not sure if this should support indexing into slices of byte or []byte (I've gone with []byte for now

Link to tracking issue

Fixes #29441

Testing

currently running make gotest (it's taking longer than I expected). I noticed that https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/35581 added to e2e_test.go. I can add a test case there, but it'll take me a bit longer to grok how those are working

Update: I'm currently getting make gotest failures on main from internal/scraper/processscraper

Documentation

changelog

znd4 commented 1 week ago

Ah, sorry I didn't get how to run just the pkg tests, and one of the other groups was causing make gotest to fail early (guessing b.c. I'm on darwin)

znd4 commented 1 week ago

@TylerHelmuth , successfully passed the unit tests now with make gotest GROUP=pkg. Sorry for the iteration