[vcenterreceiver] TLS settings not honored for initial GetServiceContent call

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector

https://opentelemetry.io

Apache License 2.0

3.1k stars 2.39k forks source link

[vcenterreceiver] TLS settings not honored for initial GetServiceContent call #36482

Open dehaansa opened 1 day ago

dehaansa commented 1 day ago

Description

The govmomi client used in the receiver attempts to validate the connection to vcenter before the existing code sets the TLS options (other than insecure) in the client. This is a limitation of the govmomi wrapper, as discussed on this issue: https://github.com/vmware/govmomi/issues/1200 .

Link to tracking issue

Related issue in Grafana Alloy: https://github.com/grafana/alloy/issues/193

Testing

~~This has not been tested, I would appreciate the assistance of any codeowner that could test.~~ See comments on the PR for test.

linux-foundation-easycla[bot] commented 1 day ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: dehaansa / name: Sam DeHaan (834d775e4e4fe345dbed80b2afbefe6334b74884, 498d00754ab003668a998b2b5cc6166df73d3622, 1bc7f34aed8db88e274c0e9dc25281d3f215cf41, 53a2d2807bbd10092e57bfa3b817c0e5f32f8bb5, 41f299a6d9efe4b1284d2e35ff2302baa23228f0, b7a14fd09d490bb701789cdb47df7a5b04a5fd2e)

schmikei commented 18 hours ago

I've tested with a variety of TLS settings (using mitmproxy) and things seem good to me and based off those related issues it does seem like underlying client TLS settings should be set this way.