[exporters/splunkhec] TraceID and SpanID aren't included in log events

open-telemetry / opentelemetry-collector-contrib

Contrib repository for the OpenTelemetry Collector

https://opentelemetry.io

Apache License 2.0

3.13k stars 2.4k forks source link

[exporters/splunkhec] TraceID and SpanID aren't included in log events #3807

Closed jrcamp closed 3 years ago

jrcamp commented 3 years ago

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/fa68c59476a33009aecbb925d4f1304e95d6e3ec/exporter/splunkhecexporter/logdata_to_splunk.go#L41

@breedx-splk reports neither TraceID nor SpanID on the LogRecords are sent. Need to decide what to name them in the HEC field.

@tigrannajaryan thoughts on naming these for the HEC output? I didn't see a semantic convention for them since I guess they're part of the record itself.

breedx-splk commented 3 years ago

Hey @jrcamp the current thought is to follow the spec and use underscores. Cool?

tigrannajaryan commented 3 years ago

@tigrannajaryan thoughts on naming these for the HEC output? I didn't see a semantic convention for them since I guess they're part of the record itself.

See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/overview.md#trace-context-in-legacy-formats