Closed mx-psi closed 1 year ago
@open-telemetry/collector-contrib-approvers, two questions about this:
tracegen
and metricgen
into a single otlpgen
tool?I think having this become a telemetrygen
makes sense to me, as it's likely the same tool would also be useful for logs. I'm happy to sponsor it.
+1 for one telemetrygen
binary. Consider also to move it to /cmd/telemetrygen
, maybe we can also publish the docker :)
Publishing an image would be awesome
I didn't see a separate issue for telemetrygen logs
- should that be included here or raised in another issue?
I didn't see a separate issue for
telemetrygen logs
- should that be included here or raised in another issue?
I think this should be a separate issue
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
All 3 subtasks are complete, shall we close this issue?
I think we can close this yes
Writing this as a new component proposal, even though this is a separate tool like tracegen and not something that would be added to the collector binary
The purpose and use-cases of the new component
Similar to
tracegen
(see #955) a newtelemetrygen
tool with support for metrics would be useful for generating a controlled stream of metrics of a given type. This would be useful for:tracegen
is currently provided both as a binary and Docker image. While we don't have exact usage numbers, the Docker image seems to average ~10 downloads per day and there is user interest on keeping the tool working and adding new features as demonstrated by issues like #7308, #7080 and #6671. We expectmetricgen
would have similar user adoption.Existing solutions (e.g. using a language library) lack support for legacy metric types like summaries and are cumbersome to use for load testing.
Example configuration for the component
As much as possible, the new tool would adopt the CLI interface from
tracegen
(by creating a common internal module used by both tools). When generating metrics, it would need to have options for specifying the OTLP metric type to be generated, its aggregation temporality and monotonicity. As an example (modulo defaults and name bikesheding to be decided during implementation):Telemetry data types supported
telemetrygen
would support traces (by including the code from tracegen) and we would add support for metrics. Eventually, logs support could be added too.All metric types should be supported, including those that are not generated by language libraries like Summaries.
Sponsor (Optional)
I am happy to sponsor this. Other Datadog employees will contribute in the development and maintenance.
Roadmap
This roadmap will be kept updated to track issues related to telemetrygen.
Phase 1: Moving from
tracegen
totelemetrygen
tracegen
intotelemetrygen traces
subcommandtracegen
in favor oftelemetrygen