Open dmitryax opened 2 years ago
Looks like introduced after https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/9335
@dehaansa can you please take a look?
Another failure in main branch https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6315386021?check_suite_focus=true
Reopening this, as it was observed again here: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6938319015?check_suite_focus=true#step:7:1137
Seeing this failure again here: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/7731126143?check_suite_focus=true#step:7:1220
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Resolved by #17079
Trying to fix this with #21530 and following up on https://github.com/open-telemetry/opentelemetry-collector/issues/7634 so we avoid using time.Sleep at all in our tests.
Definitely we should avoid time.Sleep, but we cannot also block infinitely. Why the Eventuallyf
is not working?
Seen in https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6313031997?check_suite_focus=true