search

open-telemetry / opentelemetry-collector-releases

OpenTelemetry Collector Official Releases
https://opentelemetry.io
Apache License 2.0
218 stars 130 forks source link

Make the command name consistent across images #528

Open dmitryax opened 2 months ago

dmitryax commented 2 months ago

Currently, we use different commands for different images.

Is there any value to having a unique command in each distro?

If not, we could use /otelcol consistently for every image.

We can make this change gradually and support both old and new names for some time.

Initially brought in https://github.com/open-telemetry/opentelemetry-helm-charts/pull/1148#discussion_r1567939304

mx-psi commented 2 months ago

cc @jpkrohling

codeboten commented 2 months ago

The different configuration files is also confusing..

codeboten commented 2 months ago

As discussed in 17-Apr-2024 - The same command could just be a symlink to ensure the change isn't breaking backwards compatibility

codeboten commented 2 months ago

Opened a separate issue for configuration consistency: https://github.com/open-telemetry/opentelemetry-collector-releases/issues/530

mx-psi commented 2 months ago

I pinged Juraci because I think this was intentional (see https://github.com/open-telemetry/opentelemetry-collector-releases/issues/59#issuecomment-1014451868)

TylerHelmuth commented 2 months ago

@dmitryax if we wanted to take advantage of the entrypoint in the helm chart like @jaronoff97 mentioned we'll need to update the container to use args instead of command.

TylerHelmuth commented 2 months ago

Created https://github.com/open-telemetry/opentelemetry-helm-charts/pull/1149 for the helm chart.

jpkrohling commented 2 months ago

The idea behind both the config files being at different locations, and the binary names being different, is that different distributions could be installed via OS packages (rpm/deb) without interfering. From here, we have a few options: